Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The deposit structure supports bridge scene,add l2_hash field #110

Merged
merged 1 commit into from
Dec 4, 2023
Merged

The deposit structure supports bridge scene,add l2_hash field #110

merged 1 commit into from
Dec 4, 2023

Conversation

zk-robin
Copy link
Contributor

@zk-robin zk-robin commented Dec 4, 2023 •
edited
Loading

resolves #111

@zk-robin zk-robin self-assigned this Dec 4, 2023
@zk-robin zk-robin added the enhancement New feature or request label Dec 4, 2023
@zk-robin zk-robin force-pushed the bridge_deposit branch 2 times, most recently from 391a848 to e1fc252 Compare December 4, 2023 07:29
Fred0327
Fred0327 suggested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Fred0327 Fred0327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. add a unit test with both eth_hash and l2_hash
  2. update the Changelog.md

types/src/tx_type/deposit.rs Show resolved Hide resolved
@zk-robin zk-robin force-pushed the bridge_deposit branch 2 times, most recently from 3aee93e to 2652e03 Compare December 4, 2023 11:59
@Fred0327 Fred0327 merged commit 7ab31e0 into main Dec 4, 2023
10 checks passed
@Fred0327 Fred0327 deleted the bridge_deposit branch December 4, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fred0327 Fred0327 Fred0327 approved these changes

Assignees

@zk-robin zk-robin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deposit struct support bridge scene
2 participants
@zk-robin @Fred0327